✨(frontend) adjust doc emoji behaviour and introduce emoji picker #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaurendeau
changed the title
olaurendeau
changed the title
olaurendeau
force-pushed
the
feat/emoji-design-updates
branch
from
0586dbb to
6567267
Compare
9 tasks
olaurendeau
force-pushed
the
feat/emoji-design-updates
branch
4 times, most recently
from
9f4562a to
54aeeaa
Compare
|
Thanks @olaurendeau ! |
AntoLC
reviewed
Sep 19, 2025
There was a problem hiding this comment.
It works well ! Thank you 🎉
Mainly minor comments.
Under the Figma url, to be iso with what has made @rl-83 :
https://www.figma.com/design/qdCWR4tTUr7vQSecEjCyqO/DOCS?node-id=10856-18743&t=YHWKAzs0R27yHARe-0
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Show resolved
Hide resolved
...s/doc-editor/components/custom-inline-content/Interlinking/InterlinkingLinkInlineContent.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/hooks/useDocTitleUpdate.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/hooks/useDocTitleUpdate.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/components/DocIcon.tsx
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Sep 19, 2025
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocTreeItemActions.tsx
Outdated
Show resolved
Hide resolved
AntoLC
reviewed
Sep 19, 2025
src/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/components/DocIcon.tsx
Show resolved
Hide resolved
olaurendeau
force-pushed
the
feat/emoji-design-updates
branch
from
d52b240 to
d96fcf6
Compare
olaurendeau
force-pushed
the
feat/emoji-design-updates
branch
from
d96fcf6 to
8957c85
Compare
AntoLC
reviewed
Sep 26, 2025
src/frontend/apps/impress/src/features/docs/doc-management/components/DocIcon.tsx
Show resolved
Hide resolved
olaurendeau
force-pushed
the
feat/emoji-design-updates
branch
3 times, most recently
from
f40d864 to
06176fd
Compare
|
Ok @AntoLC I believe that I've taken into consideration all your comments ! |
AntoLC
force-pushed
the
feat/emoji-design-updates
branch
2 times, most recently
from
66dbf8c to
8ff1914
Compare
We decided to not display the leading emoji as page icon on the main pages to keep consistency in the document list.
This allows users to easily add emojis easily to their documents from the tree, enhancing the overall user experience.
Add action button to remove emoji from a document title from the document tree.
Emoji in interlinking were not replacing the default icon when present.
We can now add emojis to the document title using the EmojiPicker component.
The EmojiPicker component now displays an overlay when opened, it fixes an issue when multiple pickers are present on the same page and we click on one of them, the others were not closing.
AntoLC
force-pushed
the
feat/emoji-design-updates
branch
from
8ff1914 to
9d3c1eb
Compare
AntoLC
approved these changes
Oct 23, 2025
|
Thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adjust the behaviors of Doc title emojis in Home page, Doc tree and Doc editor following discussion on #1358 (comment)
Here is a video displaying those new behaviours
Proposal
Illustrations
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)